Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] implement rust embedded kvs benchmark #2523

Closed
wants to merge 11 commits into from
Closed

[WIP] implement rust embedded kvs benchmark #2523

wants to merge 11 commits into from

Conversation

kmrmt
Copy link
Contributor

@kmrmt kmrmt commented Jul 1, 2024

Description

add benchmark for rust embedded KVS.
run benchmark with following command:

$ cargo bench -p kvs

Related Issue

Versions

  • Go Version: 1.22.3
  • Rust Version: 1.77.2
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.30.0
  • NGT Version: 2.2.1

Checklist

Special notes for your reviewer

@kmrmt
implement kvs benchmark
a4f9a34 
Signed-off-by: Kosuke Morimoto <[email protected]>
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 1, 2024 •
edited
Loading

Important

Review skipped

Ignore keyword(s) in the title.

Ignored keywords (3)
  • WIP
  • DO NOT MERGE
  • DNM

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 1, 2024

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kmrmt
add divan benchmark
0cf1eb4 
Signed-off-by: Kosuke Morimoto <[email protected]>
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 3, 2024 •
edited
Loading

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: 22996c3
Status: ✅  Deploy successful!
Preview URL: https://82221ac0.vald.pages.dev
Branch Preview URL: https://benchmark-agent-rust-kvs.vald.pages.dev

View logs

@kmrmt

This comment was marked as outdated.

Sign in to view
@kmrmt
add hand written benchmark
0ae6e98 
Signed-off-by: Kosuke Morimoto <[email protected]>
@kmrmt
add hand written benchmark result
a0b55df 
Signed-off-by: Kosuke Morimoto <[email protected]>
@kmrmt
fix unit
ce4d0cf 
Signed-off-by: Kosuke Morimoto <[email protected]>
@kmrmt
add parallel benchmark
3a03c78 
Signed-off-by: Kosuke Morimoto <[email protected]>
@kmrmt
update
d6fa632
@kmrmt
fix
4f1938d 
Signed-off-by: Kosuke Morimoto <[email protected]>
@kmrmt
add result
3f32dfe 
Signed-off-by: Kosuke Morimoto <[email protected]>
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
Closed
@kmrmt
add range
7a9810d 
Signed-off-by: Kosuke Morimoto <[email protected]>
@kmrmt
add range result
22996c3 
Signed-off-by: Kosuke Morimoto <[email protected]>
@kmrmt kmrmt changed the title [WIP] implement kvs benchmark [WIP] implement rust embedded kvs benchmark Aug 6, 2024
@kmrmt kmrmt closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority/low size/XXXL type/bench
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmrmt @vdaas-ci